[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-23 Thread Andrew Savonichev via Phabricator via cfe-commits
asavonic closed this revision. asavonic added a comment. Committed revision 345044 https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-19 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd added a comment. Ping https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-11 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd updated this revision to Diff 169188. sidorovd added a comment. - Forgot to add clarification comments on conditional branching. Added. https://reviews.llvm.org/D51402 Files: Headers/opencl-c-header.cl Headers/opencl-c.h Index: Headers/opencl-c-header.cl

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-11 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd updated this revision to Diff 169187. sidorovd added a comment. Moved the test to test/Headers/opencl-c-header.cl https://reviews.llvm.org/D51402 Files: Headers/opencl-c-header.cl Headers/opencl-c.h Index: Headers/opencl-c-header.cl ===

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-09 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D51402#1252619, @sidorovd wrote: > @Anastasia , since there is a problem I described, wouldn't you mind if I > stay with the first iteration of the patch (adding the extension to > OpenCLExtensions.def) and after we'll investigate what is w

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-10-02 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd added a comment. @Anastasia , since there is a problem I described, wouldn't you mind if I stay with the first iteration of the patch (adding the extension to OpenCLExtensions.def) and after we'll investigate what is wrong with -cl-ext approach? https://reviews.llvm.org/D51402 ___

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-09-26 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd added inline comments. Comment at: lib/Headers/opencl-c.h:26 +#if __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#ifndef cl_intel_planar_yuv +#define cl_intel_planar_yuv Anastasia wrote: > Anastasia wrote: > > @yaxunl, do you think we need to add some kind of a

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-09-20 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:26 +#if __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#ifndef cl_intel_planar_yuv +#define cl_intel_planar_yuv Anastasia wrote: > @yaxunl, do you think we need to add some kind of architecture guard fo

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-09-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:26 +#if __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#ifndef cl_intel_planar_yuv +#define cl_intel_planar_yuv @yaxunl, do you think we need to add some kind of architecture guard for such things? Lik

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-09-06 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd updated this revision to Diff 164157. sidorovd added a comment. I'm not sure if I put pragmas in an appropriate place (I mean in the very beginning of the header). https://reviews.llvm.org/D51402 Files: lib/Headers/opencl-c.h test/SemaOpenCL/extension-version.cl Index: test/Sema

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-08-29 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Will this extension require any Clang changes that are not possible to add using this approach for vendor extensions: https://clang.llvm.org/docs/UsersManual.html#opencl-extensions If not I would suggest to add this to the header file instead. Repository: rC Clang

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

2018-08-29 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd created this revision. sidorovd added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. Just adding a preprocessor #define for the extension. Patch by Alexey Sotkin Repository: rC Clang https://reviews.llvm.org/D51402 Files: include/clang/Basic/OpenCLExtension