[PATCH] D51521: Refactor Addlibgcc to make the when and what logic more straightfoward.

2018-08-31 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine closed this revision. saugustine added a comment. commited as r341231. Repository: rC Clang https://reviews.llvm.org/D51521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51521: Refactor Addlibgcc to make the when and what logic more straightfoward.

2018-08-31 Thread Stephen Hines via Phabricator via cfe-commits
srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up and adding better checks for Android. :) Repository: rC Clang https://reviews.llvm.org/D51521 ___ cfe-commits

[PATCH] D51521: Refactor Addlibgcc to make the when and what logic more straightfoward.

2018-08-30 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. LGTM, but let's get Stephen to ack as well. Repository: rC Clang https://reviews.llvm.org/D51521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51521: Refactor Addlibgcc to make the when and what logic more straightfoward.

2018-08-30 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine created this revision. saugustine added a reviewer: srhines. Herald added a subscriber: cfe-commits. Refactor Addlibgcc to make the when and what logic more straightfoward. No functional change. A forthcoming change will add support for -shared-libgcc. Repository: rC Clang