This revision was automatically updated to reflect the committed changes.
Closed by commit rL341472: Enable DWARF accelerator tables by default when
tuning for lldb (-glldb =… (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good to me & the answers to others various questions seem well addressed.
Repository:
rC Clang
https://reviews.llvm.org/D51576
___
aprantl added a comment.
In https://reviews.llvm.org/D51576#1223562, @labath wrote:
> The interactions here are a bit weird, but the short answer is no, this will
> not affect apple tables in any way.
Then I have no problem with this patch :-)
Repository:
rC Clang
labath added a comment.
In https://reviews.llvm.org/D51576#1223596, @clayborg wrote:
> We want to ensure that both Apple and DWARF5 tables never get generated
> though. That would waste a lot of space. I would say if DWARF5 tables are
> enabled, then we need ensure we disable Apple tables.
clayborg added a comment.
Actually, we might need to still emit some Apple tables as the objective C and
namespace tables might still be needed even with the DWARF5 tables.
Repository:
rC Clang
https://reviews.llvm.org/D51576
___
cfe-commits
clayborg added a comment.
We want to ensure that both Apple and DWARF5 tables never get generated though.
That would waste a lot of space. I would say if DWARF5 tables are enabled, then
we need ensure we disable Apple tables.
Repository:
rC Clang
https://reviews.llvm.org/D51576
labath added a comment.
In https://reviews.llvm.org/D51576#1223234, @aprantl wrote:
> This is DWARF5+ only, right? (We shouldn't change the preference of Apple
> accelerator tables for DWARF 4 and earlier).
The interactions here are a bit weird, but the short answer is no, this will
not
aprantl added a comment.
This is DWARF5+ only, right? (We shouldn't change the preference of Apple
accelerator tables for DWARF 4 and earlier).
Repository:
rC Clang
https://reviews.llvm.org/D51576
___
cfe-commits mailing list
labath created this revision.
labath added a reviewer: dblaikie.
DWARF v5 accelerator tables provide a considerable performance
improvement for lldb and will make the default -glldb behavior same on
all targets (right now we emit apple tables on apple targets, but these
are not controlled by
