This revision was automatically updated to reflect the committed changes.
Closed by commit rL341639: [clangd] NFC: Document URIDistance (authored by
omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51691?vs=164197&id=164372#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341639: [clangd] NFC: Document URIDistance (authored by
omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51691?vs=164197&id=164373#toc
Repository:
rL LLVM
https://review
kbobyrev updated this revision to Diff 164197.
https://reviews.llvm.org/D51691
Files:
clang-tools-extra/clangd/FileDistance.h
Index: clang-tools-extra/clangd/FileDistance.h
===
--- clang-tools-extra/clangd/FileDistance.h
+++ clan
kbobyrev marked an inline comment as done.
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/FileDistance.h:89
public:
+ // Memorizes paths from \p Sources and builds efficient structure for URI
+ // distance computations. \p Sources must contain absolute pa
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/FileDistance.h:66
// Supports lookups to find the minimum distance to a file from any source.
-// This object should be reused
kbobyrev created this revision.
kbobyrev added reviewers: sammccall, ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
`URIDistance` constructor should mention that `Sources` must contain *absolute
paths*, not URIs.
