[PATCH] D51697: [Sema] Clean up some __builtin_*_chk diagnostics

2018-09-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341566: [Sema] Clean up some __builtin_*_chk diagnostics (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51697?vs=164087&i

[PATCH] D51697: [Sema] Clean up some __builtin_*_chk diagnostics

2018-09-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D51697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D51697: [Sema] Clean up some __builtin_*_chk diagnostics

2018-09-05 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rsmith. Herald added subscribers: kristina, dexonsmith. Namely, print the likely macro name when it's used, and include the actual computed sizes in the diagnostic message, which are sometimes not obvious. rda