This revision was automatically updated to reflect the committed changes.
Closed by commit rC346732: CMake: Deprecate using llvm-config to detect llvm
installation (authored by tstellar, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51714?vs=167413&id=173808#toc
Repository
tstellar added a comment.
In https://reviews.llvm.org/D51714#1248643, @smeenai wrote:
> Is there anything holding this up?
No hold up, I just wanted to address the review comment. I'll commit on Monday
if there are no other comments.
Repository:
rC Clang
https://reviews.llvm.org/D51714
tstellar updated this revision to Diff 167413.
tstellar added a comment.
Use cmake's DEPRECATION message.
Repository:
rC Clang
https://reviews.llvm.org/D51714
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.tx
smeenai added a comment.
Is there anything holding this up?
Repository:
rC Clang
https://reviews.llvm.org/D51714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
Brilliant, I've wanted to do this for years, and I still have many improvements
to the LLVM/Clang cmake files on my todo list. Good to know others are
similarly motivated.
=
mgorny added a comment.
I don't have a strong opinion here.
Repository:
rC Clang
https://reviews.llvm.org/D51714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar added a comment.
In https://reviews.llvm.org/D51714#1225545, @mgorny wrote:
> Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for
> everyone who has LLVM configured.
Yes, it is dropped from the cache, is it a problem to having the warning fire
for people who
mgorny added a comment.
Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for
everyone who has LLVM configured.
Repository:
rC Clang
https://reviews.llvm.org/D51714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
tstellar created this revision.
tstellar added reviewers: chandlerc, beanz, mgorny, chapuni.
Herald added subscribers: dexonsmith, mehdi_amini.
clang currently uses llvm-config to determine the installation paths
for llvm's headers and binaries. clang is also using LLVM's cmake
files to determine
