Lekensteyn added a comment.
In https://reviews.llvm.org/D51729#1288360, @sammccall wrote:
> > I'm not entirely sure what to do here. The old behavior works great in
> > cases where a complete database is available (produced by CMake). The new
> > behavior might work better for clangd (?), but
sammccall added a comment.
In https://reviews.llvm.org/D51729#1287421, @Lekensteyn wrote:
> Before this patch, missing compilation database entries resulted in "Skipping
> Compile command not found." which is assumed by the tests in this
> clang-query patch:
Lekensteyn added a comment.
Before this patch, missing compilation database entries resulted in "Skipping
Compile command not found." which is assumed by the tests in this
clang-query patch: https://reviews.llvm.org/D54109
After this patch, a command is inferred, but this is not always
Sorry about that. I wasn't familiar with the python bindings.
Your bisect is correct, we changed the behavior that test is testing: now
an approximate match will be returned.
I guess either:
- just remove that test (depending on how we feel about smoke-testing vs
exhaustively testing wrapperl
mgorny added a comment.
Unless my bisect is mistaken, this broke Clang Python binding test:
https://github.com/llvm-mirror/clang/blob/master/bindings/python/tests/cindex/test_cdb.py#L34
The test apparently assumes that compilation database will not return anything
for a file that does not
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342228: [Tooling] JSONCompilationDatabasePlugin infers
compile commands for missing… (authored by sammccall, committed by ).
Changed prior to commit:
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I like it
Repository:
rC Clang
https://reviews.llvm.org/D51729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall created this revision.
sammccall added a reviewer: bkramer.
Herald added subscribers: cfe-commits, kadircet, ioeric, ilya-biryukov.
See the existing InterpolatingCompilationDatabase for details on how this works.
We've been using this in clangd for a while, the heuristics seem to work
