jfb updated this revision to Diff 164481.
jfb added a comment.
- Use isBytewiseValue instead.
Repository:
rC Clang
https://reviews.llvm.org/D51752
Files:
lib/CodeGen/CGDecl.cpp
Index: lib/CodeGen/CGDecl.cpp
===
--- lib/CodeGe
jfb added a comment.
In https://reviews.llvm.org/D51752#1226474, @MatzeB wrote:
> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I assume the review lacks the changes on the llvm side?
>
>
> Oops missed the link to the llvm changes in the description... At least in
> theory y
MatzeB added a comment.
In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
> - I assume the review lacks the changes on the llvm side?
Oops missed the link to the llvm changes in the description... At least in
theory you should be able to make a review over all changes in parallel by
jfb added a comment.
In https://reviews.llvm.org/D51752#1226465, @jfb wrote:
> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I'm not a good person to review clang changes.
> > - I assume the review lacks the changes on the llvm side?
> > - On the LLVM side this feels like som
jfb added a comment.
In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
> - I'm not a good person to review clang changes.
> - I assume the review lacks the changes on the llvm side?
> - On the LLVM side this feels like something for `Analysis/ValueTracking.h`
> in fact I already see `Va
MatzeB added a comment.
- I'm not a good person to review clang changes.
- I assume the review lacks the changes on the llvm side?
- On the LLVM side this feels like something for `Analysis/ValueTracking.h` in
fact I already see `Value *isBytewiseValue(Value *V);` there, maybe that is
good enoug
jfb created this revision.
Herald added subscribers: cfe-commits, dexonsmith.
This code was in CGDecl.cpp and really belongs to Constant. This will allow me
to use it in a subsequent patch.
LLVM part of this patch: https://reviews.llvm.org/D51751
Repository:
rC Clang
https://reviews.llvm.org
