This revision was automatically updated to reflect the committed changes.
Closed by commit rL342134: [clangd] Clarify and hide -index flag. (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51977
Files:
clang-tools-ex
ioeric updated this revision to Diff 165263.
ioeric marked an inline comment as done.
ioeric added a comment.
- Remove `static`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51977
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
+1 to making this hidden. Users (most of them) shouldn't care about it.
Is there any motivation on why we someone would want to disable it currently?
Maybe we want to deprecate it
ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
The wording implies global index support, which is confusing.
As most users shouldn't care about this flag, also make it hidden to avoid
furt
