[PATCH] D52000: Feedback/direction Review for cpu-dispatch emit stage into GlobalDecl

2018-10-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane abandoned this revision. erichkeane added a comment. Herald added a subscriber: nhaehnle. Superseding with a version that seems to work Repository: rC Clang https://reviews.llvm.org/D52000 ___ cfe-commits mailing list

[PATCH] D52000: Feedback/direction Review for cpu-dispatch emit stage into GlobalDecl

2018-10-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. @aaron.ballman or @rsmith any chance you guys could give me a hand on the direction here? I'm growing GlobalDecl by quite a bit, so I want to make sure this is both permissible and the right way to go. Additionally, feedback on how to get a GlobalDecl down to

[PATCH] D52000: Feedback/direction Review for cpu-dispatch emit stage into GlobalDecl

2018-09-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added a reviewer: rsmith. Herald added a subscriber: cfe-commits. In the feedback in https://reviews.llvm.org/D51650 (https://reviews.llvm.org/D51650), @rsmith points out an implementation detail of CPU-Dispatch is improperly done. I'd like to fix