kbobyrev updated this revision to Diff 165236.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Move assertion back to ctors.
https://reviews.llvm.org/D52016
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
Index: clang-tools-extra/clangd/index/dex/Iterator.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342124: [clangd] Dont create child AND and OR
iterators with one posting list (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148
+ if (TrigramIterators.size() > 1)
ilya-biryukov added a comment.
Great improvement for such a simple change!
https://reviews.llvm.org/D52016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev updated this revision to Diff 165229.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D52016
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
Index: clang-tools-extra/clangd/index/dex/Iterator.cpp
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148
+ if (TrigramIterators.size() > 1)
TopLevelChildren.push_back(createAnd(move(TrigramIterators)));
+ else if (TrigramIterators.size() == 1)
ilya-biryukov wrote:
>
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148
+ if (TrigramIterators.size() > 1)
TopLevelChildren.push_back(createAnd(move(TrigramIterators)));
+ else if (TrigramIterators.size() == 1)
Maybe special-case a
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
`AND( AND( Child ) ... )` -> `AND( Child ... )`
`AND( OR( Child) ... )` -> `AND( Child ... )`
