[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-10-03 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. Thanks! I'll go ahead and commit this. Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-10-03 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-10-02 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. //Ping Ping// Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-10-01 Thread Matthew Voss via Phabricator via cfe-commits
ormris updated this revision to Diff 167849. ormris added a comment. - Clarify CGDebugInfo::CollectVarTemplateParams Repository: rC Clang https://reviews.llvm.org/D52058 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-template-member.cpp Index:

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-25 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. //Ping// Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-18 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. In https://reviews.llvm.org/D52058#1237868, @JDevlieghere wrote: > Generally this looks good, but I'd like for the other to have a look first > (at this and the other patch) before accepting. Sounds good. Thanks for your comments! Comment at: lib/Cod

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-18 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Generally this looks good, but I'd like for the other to have a look first (at this and the other patch) before accepting. Comment at: lib/CodeGen/CGDebugInfo.cpp:1783 + if (auto *TS = dyn_cast(VL)) { +if (TS->getSpecializedTemplateOrPartial(

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-17 Thread Matthew Voss via Phabricator via cfe-commits
ormris updated this revision to Diff 165789. ormris added a comment. - Removed unneeded comment - Renamed variable Repository: rC Clang https://reviews.llvm.org/D52058 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-template-member.cpp Index: te

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-14 Thread Matthew Voss via Phabricator via cfe-commits
ormris added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3126 + } else { +templateParameters = nullptr;//llvm::DINodeArray().get(); + } JDevlieghere wrote: > What's the meaning of this comment? Hmm... That should be removed.

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-14 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3126 + } else { +templateParameters = nullptr;//llvm::DINodeArray().get(); + } What's the meaning of this comment? Comment at: lib/CodeGen/CGDebugInfo.h:654 +

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

2018-09-13 Thread Matthew Voss via Phabricator via cfe-commits
ormris created this revision. ormris added reviewers: dblaikie, aprantl, probinson, JDevlieghere, clayborg, jingham. This patch adds the associated template parameters to the DWARF name attribute of all template variable specializations, mirroring how they are referenced in the source code. Orig