[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

dblaikie added a comment. In D52296#2165370 , @Trass3r wrote: > In D52296#1285328 , @grimar wrote: > > > In D52296#1284130 , @probinson > > wrote: > > > > > Only DWARF

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

Trass3r added a comment. Herald added a subscriber: dang. In D52296#1285328 , @grimar wrote: > In D52296#1284130 , @probinson wrote: > > > Only DWARF supports this, correct? > > > I am not aware of any kind of

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

This revision was automatically updated to reflect the committed changes. Closed by commit rC346837: [Clang] - Add -gsplit-dwarf[=split,=single] version for -gsplit-dwarf… (authored by grimar, committed by ). Changed prior to commit: https://reviews.llvm.org/D52296?vs=173643=173998#toc

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:813-830 + if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) +if (StringRef(A->getValue()) ==

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

grimar added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:813-830 + if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) +if (StringRef(A->getValue()) == "single") + return Args.MakeArgString(Output.getFilename()); + Arg *FinalOutput =

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

grimar added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:813-830 + if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) +if (StringRef(A->getValue()) == "single") + return Args.MakeArgString(Output.getFilename()); + Arg *FinalOutput =

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

dblaikie added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:813-830 + if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) +if (StringRef(A->getValue()) == "single") + return Args.MakeArgString(Output.getFilename()); + Arg *FinalOutput =

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

grimar updated this revision to Diff 173643. grimar retitled this revision from "[Clang] - Add -fdwarf-fission=split,single option." to "[Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option.". grimar edited the summary of this revision. grimar added a comment.