[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

dblaikie added a comment. OK - thanks for that. I'm going to make an executive decision on the naming. Let's go with -gsplit-dwarf[=single] (or explicitly -gsplit-dwarf=split, which is the default value when -gsplit-dwarf is specified). Saves adding a new name/flag, avoids the use of the word

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5889 const llvm::Triple = getToolChain().getTriple(); - if (Args.hasArg(options::OPT_gsplit_dwarf) && + if ((getDebugFissionKind(D, Args) == DwarfFissionKind::Split) && (T.isOSLinux() ||

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar added a comment. Looks like this behavior is what clang already have atm. Messages for the options that use `D.Diag` to report invalid values can be printed multiple times sometimes. The example is below: clang main.cpp -fdwarf-fission=foo -o 1.o -mthread-model bar

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5889 const llvm::Triple = getToolChain().getTriple(); - if (Args.hasArg(options::OPT_gsplit_dwarf) && + if ((getDebugFissionKind(D, Args) == DwarfFissionKind::Split) && (T.isOSLinux() ||

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5889 const llvm::Triple = getToolChain().getTriple(); - if (Args.hasArg(options::OPT_gsplit_dwarf) && + if ((getDebugFissionKind(D, Args) == DwarfFissionKind::Split) && (T.isOSLinux() ||

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

probinson added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5889 const llvm::Triple = getToolChain().getTriple(); - if (Args.hasArg(options::OPT_gsplit_dwarf) && + if ((getDebugFissionKind(D, Args) == DwarfFissionKind::Split) && (T.isOSLinux() ||

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:2999-3001 +StringRef Value = A->getOption().matches(options::OPT_fdwarf_fission_EQ) + ? A->getValue() + : "split"; dblaikie wrote: >

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar updated this revision to Diff 173135. grimar marked an inline comment as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52296 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar added a comment. In https://reviews.llvm.org/D52296#1290212, @dblaikie wrote: > Thanks! - though on reflection I'm going to invoke @echristo again about the > naming. It's unfortunately a bit backwards that the pre-standard flag is > -gsplit-dwarf and what we're proposing as the

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

dblaikie added a comment. Thanks! - though on reflection I'm going to invoke @echristo again about the naming. It's unfortunately a bit backwards that the pre-standard flag is -gsplit-dwarf and what we're proposing as the standard flag is -fdwarf-fission, when the DWARF standard doesn't use

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar updated this revision to Diff 172953. grimar retitled this revision from "[Clang] - Add -gsingle-file-split-dwarf option." to "[Clang] - Add -fdwarf-fission=split,single option.". grimar added a comment. Reimplemented option as `-fdwarf-fission[=split,single]`.