This revision was automatically updated to reflect the committed changes.
Closed by commit rL342758: Add necessary support for storing code-model to
module IR. (authored by ctice, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cmtice updated this revision to Diff 166492.
cmtice edited the summary of this revision.
cmtice added a comment.
Move include statement from CodeGenModule.h to CodeGenModule.cpp
Remove incorrect "default" case statement.
Add test for "tiny" code model.
https://reviews.llvm.org/D52323
Files:
cmtice marked an inline comment as done.
cmtice added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+ .Default(~0u);
+if ((CM != ~0u) && (CM != ~1u)) {
+ llvm::CodeModel::Model codeModel =
static_cast(CM);
tejohnson
tejohnson added a comment.
Note that if you add a line like:
"Depends on https://reviews.llvm.org/D52322; in the summary that Phabricator
will automatically link the two in the right way.
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+ .Default(~0u);
+if
cmtice created this revision.
cmtice added reviewers: tejohnson, pcc.
Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini.
Currently the code-model does not get saved in the module IR, so if a code
model is specified when compiling with LTO, it gets lost and is not propagated
