This revision was automatically updated to reflect the committed changes.
Closed by commit rL342764: [libc++abi] is_strcmp parameter to is_equal is
unused for WIN32 (authored by pirama, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama updated this revision to Diff 166527.
pirama added a comment.
Simplify patch.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
Files:
src/private_typeinfo.cpp
Index: src/private_typeinfo.cpp
===
---
mclow.lists added a comment.
This seems like overkill to me; why not add `(void) use_strcmp` right before
line 67 instead?
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama created this revision.
pirama added reviewers: EricWF, srhines, mstorsjo.
Herald added subscribers: libcxx-commits, ldionne, christof.
Mark it as unused to avoid -Wunused-parameter.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
Files:
src/private_typeinfo.cpp
Index:
