This revision was automatically updated to reflect the committed changes.
Closed by commit rL343066: [clangd] Handle template args for disabled function
arg snippets (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:507
+ if (Snippet->front() == '<')
+return EmptyArgs ? "<$0>()" : "<$1>($0)";
+ if (Snippet->front() == '(')
kadircet wrote:
ilya-biryukov updated this revision to Diff 167044.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Remove debug formatting
- Update snippet for no-arg case with the suggested changes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52422
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/CodeComplete.cpp:507
+ if (Snippet->front() == '<')
+return EmptyArgs ? "<$0>()" : "<$1>($0)";
+ if (Snippet->front() == '(')
--
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:1699
+ if (Opts.EnableSnippets) {
+log("Suffix: {0}", SnippetSuffix);
LSP.textEdit->newText += SnippetSuffix;
Sorry, leftover from debug printing. Will remove
Repository:
rCTE
ilya-biryukov created this revision.
ilya-biryukov added reviewers: kadircet, ioeric, sammccall.
Herald added subscribers: arphaman, jkorous, MaskRay.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52422
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
I
