echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52441#1271545, @rnk wrote:
> In https://reviews.llvm.org/D52441#1258317, @craig.topper wrote:
>
> > Address Reid's comments. Add a comment with a list of all
rnk added a comment.
In https://reviews.llvm.org/D52441#1258317, @craig.topper wrote:
> Address Reid's comments. Add a comment with a list of all things that
> currently effect the vector width attribute emitted in IR.
>
> For inlining, we update the caller's attribute during merging to ensure
craig.topper added a comment.
Ping
https://reviews.llvm.org/D52441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
Couple of comments/questions:
a) How do you want these attributes to be handled in merging/inlining? Also,
are they a failure on module linking? In general, how do they work with LTO?
b) Could use some more comments when we're adding/merging the attributes in IR
rnk added a comment.
Code looks fine, but attribute testing is always a pain.
Comment at: test/CodeGen/aarch64-neon-3v.c:14
-// CHECK-LABEL: define <16 x i8> @test_vandq_s8(<16 x i8> %a, <16 x i8> %b) #0
{
// CHECK: [[AND_I:%.*]] = and <16 x i8> %a, %b
craig.topper added a comment.
Herald added a subscriber: arphaman.
Ping
https://reviews.llvm.org/D52441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
