This revision was automatically updated to reflect the committed changes.
Closed by commit rC344010: [Index] Use locations to uniquify function-scope
BindingDecl USR (authored by MaskRay, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52445?vs=168704=168740#toc
Repository:
MaskRay updated this revision to Diff 168704.
MaskRay added a comment.
Use isLocal
Repository:
rC Clang
https://reviews.llvm.org/D52445
Files:
lib/Index/USRGeneration.cpp
test/Index/Core/index-source.cpp
Index: test/Index/Core/index-source.cpp
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The change looks reasonable to me, so lg. I'd wait a bit to see whether other
reviewers have comments.
Comment at: lib/Index/USRGeneration.cpp:339
+void
MaskRay updated this revision to Diff 168486.
MaskRay added a comment.
Add test to Core/index-source.cpp
Repository:
rC Clang
https://reviews.llvm.org/D52445
Files:
lib/Index/USRGeneration.cpp
test/Index/Core/index-source.cpp
Index: test/Index/Core/index-source.cpp
hokein added a comment.
Can you add a test?
Repository:
rC Clang
https://reviews.llvm.org/D52445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D52445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay created this revision.
MaskRay added reviewers: akyrtzi, arphaman.
Herald added a subscriber: cfe-commits.
This makes BindingDecl's of the same name have different USRs, so that
references can be correctly attributed.
int a[1] = {};
{ auto [x] = a; x; }
{ auto [x] = a; x; }
