owenpan closed this revision.
owenpan added a comment.
llvm-svn: 357957
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52527/new/
https://reviews.llvm.org/D52527
___
cfe-commits mailing list
owenpan added a comment.
@MyDeveloperDay :
> do you happen to know if this script is run by the build or is supposed to be
> run by the developer after making the change to Format.h
I believe the developer must run it manually.
> If the latter, then I reckon the two are out of sync, perhaps I
owenpan updated this revision to Diff 194219.
owenpan added a reviewer: reuk.
owenpan added a comment.
Thank you to all for reviewing this revision! Here is the update that addresses
all of your comments.
(Also added @reuk to the reviewer list per @MyDeveloperDay 's suggestion.)
Repository:
MyDeveloperDay added a subscriber: reuk.
MyDeveloperDay added a comment.
@ownenpan might be worth checking with @reuk who has been adding some options
for the JUCE style guide and looking at the JUCE code it seems this style might
match their style.
Comment at:
krasimir added inline comments.
Comment at: include/clang/Format/Format.h:638
+/// \endcode
+bool AfterCaseLabel;
/// Wrap class definitions.
This comment seems outdated (the one in `ClangFormatStyleOptions.rst` seems
more recent).
The
klimek accepted this revision.
klimek added a comment.
Apart from the typo I think this is a simple enough change and a widely enough
used style that it LG.
Comment at: lib/Format/UnwrappedLineParser.cpp:181
+ CompoundStatementIndenter(UnwrappedLineParser *Parser, unsigned ,
owenpan added a comment.
@MyDeveloperDay: Can you add a link to the bugzilla report?
I stopped pushing my solution because as @krasimir said it's probably not a bug
although the current documentation doesn't spell it out. Nonetheless, I'm with
you and would like to see this improvement
MyDeveloperDay added a comment.
Herald added a project: clang.
@owenpan can I help you bring this back up to date and review, I think I saw
another issue in the bugzilla requesting this.
I know the code owners like new option to have a style guide used by a large
code base, but to me this
krasimir requested changes to this revision.
krasimir added a comment.
This revision now requires changes to proceed.
OK, so this is not a real bug in the sense of non-working current features,
it's more like a feature request.
As per
owenpan added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D52527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
In https://reviews.llvm.org/D52527#1257277, @owenpan wrote:
> I'd greatly appreciate it if someone could review this before I commit it
> next week.
Please do not commit without review. It is ok, to write `ping` every 5-7 days
if there is no comment from the
On Sat, Oct 6, 2018 at 10:06 PM Owen Pan via Phabricator via
cfe-commits wrote:
>
> owenpan added a comment.
>
> I'd greatly appreciate it if someone could review this before I commit it
> next week.
That is not how LLVM reviews work.
Commit-without-review mostly is only for NFC changes in the
owenpan added a comment.
I'd greatly appreciate it if someone could review this before I commit it next
week.
Repository:
rC Clang
https://reviews.llvm.org/D52527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
owenpan updated this revision to Diff 167225.
owenpan added a comment.
Updated ClangFormatStyleOptions.rst.
Repository:
rC Clang
https://reviews.llvm.org/D52527
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
owenpan created this revision.
owenpan added reviewers: sammccall, klimek, djasper, krasimir.
Herald added a subscriber: cfe-commits.
https://bugs.llvm.org/show_bug.cgi?id=38686
Repository:
rC Clang
https://reviews.llvm.org/D52527
Files:
include/clang/Format/Format.h
15 matches
Mail list logo
