[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

2018-10-05 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D52684#1250885, @JonasToth wrote: > This patch is related to https://reviews.llvm.org/D51949 > > To isolate variable declarations (split `int * p, v;` up) it is nece

[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

2018-10-01 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. This patch is related to https://reviews.llvm.org/D51949 To isolate variable declarations (split `int * p, v;` up) it is necessary to do a lot of work with source location and requires some forward and backwards lexing. The functions there just use the LangOpts and th

[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

2018-10-01 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. So far the change doesn't look really helpful. Are you going to use the function from code where no `ASTContext` is available? Can you give an example? Repository: rCTE Clang Tool

[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

2018-09-29 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 167592. JonasToth added a comment. - fix missing file Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52684 Files: clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tidy/bugprone/SuspiciousSemicolonCheck.cpp clang-tidy/cppcoreguidel

[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

2018-09-29 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. JonasToth added a project: clang-tools-extra. This patch is a small refactoring necessary for 'readability-isolate-declaration' and does n