This revision was automatically updated to reflect the committed changes.
Closed by commit rC344100: clang: Allow ifunc resolvers to accept arguments
(authored by emaste, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52703
Files:
include/clang/Basic/AttrDocs.td
include/cl
SGTM.
On Tue, Oct 9, 2018, 7:57 AM James Y Knight via Phabricator <
revi...@reviews.llvm.org> wrote:
> jyknight accepted this revision.
> jyknight added a comment.
> This revision is now accepted and ready to land.
>
> Given that there's no technical reason for the compiler to prohibit this
> (it
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Given that there's no technical reason for the compiler to prohibit this (it
was just clang trying to diagnose a probable user-error, which turns out to not
be as probable as ), this seems
emaste created this revision.
emaste added a reviewer: DmitryPolukhin.
Herald added a reviewer: javed.absar.
Herald added subscribers: kristof.beyls, krytarowski.
When ifunc support was added to Clang (in https://reviews.llvm.org/rC265917) it
did not allow resolvers to take function arguments. Th