[PATCH] D52714: Build clang-headers when building clang tools.

2018-10-01 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343459: Build clang-headers when building clang tools. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52714 Files: cfe/tr

[PATCH] D52714: Build clang-headers when building clang tools.

2018-10-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. > when we build clangd via ninja clangd, we expect the binary can run on > real-world project FWIW, I don't particularly have this expectation - I expect to be able to run the tests, an

[PATCH] D52714: Build clang-headers when building clang tools.

2018-10-01 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, ioeric, ilya-biryukov, mgorny. clang tools require clang headers to work on real project, e.g. when we build clangd via `ninja clangd`, we expect the binary can run on real-world project (without