This revision was automatically updated to reflect the committed changes.
Closed by commit rL345724: [analyzer][PlistMacroExpansion] Part 1.: New
expand-macros flag (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:471
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
-
xazax.hun accepted this revision.
xazax.hun added a comment.
LGTM! Thanks, I think it is much easier to understand what is going on this way.
https://reviews.llvm.org/D52742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Szelethus updated this revision to Diff 171533.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/BugReporter.cpp
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/Input
Szelethus updated this revision to Diff 171532.
Szelethus added a comment.
This revision is now accepted and ready to land.
Changes according to my last comment.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOption
Szelethus planned changes to this revision.
Szelethus added a comment.
@xazax.hun observed that the way `diagnostics` looks like is this:
diagnostics
report 1
notes
macro_expansions
path
executed_lines
report 2
...
Bt, if I didn't insist on this struct
NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:17-18
+
+ name
+ expansion
+
NoQ wrote:
> They look em
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:471
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
Yup, np, let's wait until it lands the
Szelethus updated this revision to Diff 170509.
Szelethus added a comment.
Added a new `macro_expansions` key on the same level at `path` and `notes`,
under which the macro expansions are listed, as suggested by @NoQ.
There were a couple ways to make this happen. I could've changed how macro
pi
Szelethus marked 3 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:469
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
-
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:469
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
Should we say something about plists i
Szelethus updated this revision to Diff 169858.
Szelethus added a comment.
Removed the version entry from the plist file.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/BugRepor
whisperity added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:346
+
+
/home/eumakri/Documents/2codechecker_dev_env/llvm/tools/clang/test/Analysis/plist-macros-with-expansion.cpp
+
Same here, as @xaza
xazax.hun added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
+ clang_version
+clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
85a6dda64587a5a18482f091cbcf020fbd3ec1dd) (https://github.com/llvm-mirro
Szelethus updated this revision to Diff 168320.
Szelethus marked an inline comment as done.
https://reviews.llvm.org/D52742
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/BugReporter.cpp
lib/StaticAnalyzer/Cor
Szelethus marked 3 inline comments as done.
Szelethus added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
+ clang_version
+clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
85a6dda64587a5a18482f091cbcf
whisperity added inline comments.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6
+ clang_version
+clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang
85a6dda64587a5a18482f091cbcf020fbd3ec1dd) (https://github.com/llvm-mirr
Szelethus updated this revision to Diff 167992.
Szelethus retitled this revision from "[analyzer][WIP] Add macro expansions to
the plist output" to "[analyzer][PlistMacroExpansion] Part 1.: New
expand-macros flag".
Szelethus edited the summary of this revision.
Szelethus removed reviewers: xazax.
18 matches
Mail list logo
