[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:755 +if (It->is(tok::l_paren)) { + while ((++It)->isNot(tok::r_paren)) { +assert(It->isNot(tok::eof) && donat.nagy wrote: > I fear that this doe

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

donat.nagy added a comment. Does this checker handle the expansion of variadic macros introduced in C++11 (see syntax (3) and (4) here ) and the `#` and `##` preprocessor operators? Comment at: lib/StaticAnalyzer/Core/P

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus marked 13 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:292 + + // Output the location. + FullSourceLoc L = P.getLocation().asLocation(); whisperity wrote: > the location of what? Th

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus updated this revision to Diff 167924. Szelethus added a comment. - Fixes according to @whisperity's comments - New test cases for - commas in brackets, - commas in braces, - macro arguments left empty. > (The whole thing, however, is generally disgusting. I'd've expected the > Pr

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

whisperity added a subscriber: gamesh411. whisperity added a comment. Your code looks good, just minor comments going on inline. Trying to think of more cases to test for, in case someone generously misuses FLMs, as seen here in an example if you scroll down a bit: https://gcc.gnu.org/onlinedocs

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus added a reviewer: whisperity. Szelethus added a comment. We need your all-seeing hawk eye! Repository: rC Clang https://reviews.llvm.org/D52742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, dcoughlin, MTC, dkrupp. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. This is the implementation of the inclusion of macro expansions into the plist o