efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
efriedma wrote:
> efriedma wrote:
> > rnk wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343881: [COFF, ARM64] Add
_InterlockedCompareExchangePointer_nf intrinsic (authored by mgrang, committed
by ).
Repository:
rC Clang
https://reviews.llvm.org/D52807
Files:
include/clang/Basic/Builti
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
mgrang updated this revision to Diff 168403.
https://reviews.llvm.org/D52807
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-intrinsics.c
Index: test/CodeGen/ms-intrinsics.c
===
--- test/Code
mgrang added a comment.
In https://reviews.llvm.org/D52807#1255835, @efriedma wrote:
> How are you testing?
>
> You might see different behavior at -O0.
Yes, I was testing at -O0. At -O2 I can see monotonic ordering affect the
choice of LD/ST insts used.
https://reviews.llvm.org/D52807
__
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
efriedma wrote:
> rnk wrote:
> > mgrang wrote:
> >
efriedma added a comment.
How are you testing?
You might see different behavior at -O0.
Repository:
rC Clang
https://reviews.llvm.org/D52807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
mgrang added a comment.
AArch64 Psuedo Expansion does not seem to honor AtomicOrdering types
(SequentiallyConsistent/Monotonic). It seems to always generate LDAXRX/STLXRX
for 64-bit Cmp_Xchg.
Repository:
rC Clang
https://reviews.llvm.org/D52807
___
mgrang added a comment.
MSVC seems to generate ldaxr/stlxr (as well as dmb) for
InterlockedCompareExchangePointer and ldxr/stxr for
InterlockedCompareExchangePointer_nf.
void *test_InterlockedCompareExchangePointer(void * volatile *Destination,
v
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
mgrang wrote:
> rnk wrote:
> > Is the no fence version r
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
mgrang wrote:
> rnk wrote:
> > Is the no fence vers
mgrang added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
rnk wrote:
> Is the no fence version really equivalen
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
Is the no fence version really equivalent to this seq_cs
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul.
Herald added subscribers: jfb, chrib, kristof.beyls.
Repository:
rC Clang
https://reviews.llvm.org/D52807
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-intr
14 matches
Mail list logo
