[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-16 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Thanks for all your reports. I have filed https://reviews.llvm.org/D53326 to disable the tests on all three known-broken arches. Repository: rC Clang https://reviews.llvm.org/D52840 ___ cfe-commits mailing list

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-16 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz added a comment. Hexagon clang builder has been failing since around the time of this commit as well: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/20617/steps/ninja%20check%201/logs/stdio Repository: rC Clang https://reviews.llvm.org/D52840

Re: [PATCH] D52840: Include Python binding tests in CMake rules

2018-10-16 Thread Yvan Roux via cfe-commits
Hi Michal, AArch64 bots are broken as well, logs are available at: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/15717/steps/ninja%20check%201/logs/stdio Cheers, Yvan On Mon, 15 Oct 2018 at 20:39, Ulrich Weigand via Phabricator via cfe-commits wrote: > > uweigand added a

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-15 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. In https://reviews.llvm.org/D52840#1265615, @mgorny wrote: > The first one seems to indicate that your `libclang.so` is broken in release > mode (optimization error?). The second one is correct (some of the tests test > for errors, and apparently don't silence the

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-15 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. The first one seems to indicate that your `libclang.so` is broken in release mode (optimization error?). The second one is correct (some of the tests test for errors, and apparently don't silence the messages). Repository: rC Clang https://reviews.llvm.org/D52840

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-15 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. This causes check-all to abort for me on SystemZ in Release mode (and never actually run the lit tests): [40/365] cd /home/uweigand/llvm/llvm-head/tools/clang/bindings/python && /usr/bin/cmake -E...BRARY_PATH=/home/uweigand/llvm/build/llvm-head/lib

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC344258: [tests] Include Python binding tests in CMake rules (authored by mgorny, committed by ). Repository: rC Clang https://reviews.llvm.org/D52840 Files: CMakeLists.txt

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm not a CMake expert, but when I apply this patch locally, I'm able to run cmake to completion without errors, so LGTM! https://reviews.llvm.org/D52840

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Michał Górny via Phabricator via cfe-commits
mgorny requested review of this revision. mgorny added a comment. Please review the new version, addressing the issue caught by buildbots. https://reviews.llvm.org/D52840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 169219. mgorny added a comment. v3: one more correction for stand-alone builds. https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CMakeLists.txt Index: bindings/python/tests/CMakeLists.txt

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 169218. mgorny added a comment. v2: fixed appending to check-all to make it compatible both with in-tree and standalone builds https://reviews.llvm.org/D52840 Files: CMakeLists.txt bindings/python/tests/CMakeLists.txt Index:

Re: [PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Aaron Ballman via cfe-commits
On Thu, Oct 11, 2018 at 8:23 AM Umann Kristóf via Phabricator via llvm-commits wrote: > > Szelethus added a comment. > > I'm afraid this may have broken many buildbots, I'm having issues building > from scratch. Can you please take a look? I've reverted in r344244. ~Aaron

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. I'm afraid this may have broken many buildbots, I'm having issues building from scratch. Can you please take a look? Repository: rL LLVM https://reviews.llvm.org/D52840 ___ cfe-commits mailing list

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-11 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344241: [tests] Include Python binding tests in CMake rules (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-03 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Yes, I've tested it on Linux. I'll commit it once the dep is approved, and hopefully build bots will answer if they work across all platforms. Repository: rC Clang https://reviews.llvm.org/D52840 ___ cfe-commits mailing

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-03 Thread Stephen Kelly via Phabricator via cfe-commits
steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. I didn't run it, but CMake-wise this looks fine. (I trust you did) I notice some tests use from tests.cindex.util import foo while others use from .util import foo You might want

[PATCH] D52840: Include Python binding tests in CMake rules

2018-10-03 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: jbcoe, arphaman, frutiger. Add a new CMake rule check-clang-python to run the Python bindings' test suite, and include it in check-all. Repository: rC Clang https://reviews.llvm.org/D52840 Files: CMakeLists.txt