mwasplund abandoned this revision.
mwasplund added a comment.
I completely forgot this was open. I have been making incremental improvements
to modules ts and this has gotten pulled into that change.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52973/new/
mwasplund added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:1467-1470
+ // FIXME: The Modules TS does not specify how to handle inplicit types
+ // For now we will simply ignore the implicit global types
+ if (Old->isImplicit())
+return false;
mwasplund added a comment.
Can you see the full change? I am only seeing that latest commit after running:
"git show HEAD -U99 > mypatch.patch".
It was working fine with I ran "git diff master..mybranch > mybranch.diff"
however that does not give the full context.
Repository:
rC Clang
mwasplund added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:1464
if (NewM == OldM)
return false;
rsmith wrote:
> Somewhere up here we're calling `getOwningModule()` but should be calling
> `getOwningModuleForLinkage()`. (Please upload patches
mwasplund updated this revision to Diff 169879.
mwasplund marked 2 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D52973
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/Sema/SemaDecl.cpp
test/Modules/msvc-compat-implitic-types.cpp
Index:
rsmith added a comment.
In https://reviews.llvm.org/D52973#1259992, @mwasplund wrote:
> In https://reviews.llvm.org/D52973#1259909, @rsmith wrote:
>
> > Generally this looks good, but it needs an accompanying test.
>
>
> I was looking into that and trying to read up on the documentation for
mwasplund added a comment.
In https://reviews.llvm.org/D52973#1259909, @rsmith wrote:
> Generally this looks good, but it needs an accompanying test.
I was looking into that and trying to read up on the documentation for adding
tests. I think I understand the crazy comment RUN test
rsmith added a comment.
Generally this looks good, but it needs an accompanying test.
Comment at: include/clang/AST/ASTContext.h:1129-1130
+ /// Retrieve the declaration for the type_info class type.
+ RecordDecl *getTypeInfoClassDecl() const;
+
Please
mwasplund created this revision.
Herald added a subscriber: cfe-commits.
Bug 39052 - [Modules TS] MSVC std library produces ambiguous type_info
reference when including module with ms-compatibility
When compiling a modules-ts project with MSVC compatibility turned on the
type_info class was
