[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345418: [clang-doc] Switch to default to all-TUs executor (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D53170?vs=169414&id=171331#toc Repository: rCT

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

juliehockett updated this revision to Diff 169414. juliehockett marked 3 inline comments as done. https://reviews.llvm.org/D53170 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp =

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

ioeric added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:89 llvm::cl::init(false), llvm::cl::cat(ClangDocCategory)); +static llvm::cl::opt ClangDocExecutorName( This flag can also be removed. Users can still use `--execut

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

juliehockett updated this revision to Diff 169411. https://reviews.llvm.org/D53170 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp === --- clang-tools-extra/clang-

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

juliehockett marked 3 inline comments as done. juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:203 +llvm::Expected> +createClangDocExecutor(int &argc, const char **argv, + llvm::cl::OptionCategory &Category)

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

ioeric requested changes to this revision. ioeric added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:203 +llvm::Expected> +createClangDocExecutor(int &argc, const char **argv, +

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:205 + llvm::cl::OptionCategory &Category) { + auto OptionsParser = + CommonOptionsParser::create(argc, argv, Category, llvm::cl::ZeroOrMore); --

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

juliehockett updated this revision to Diff 169304. https://reviews.llvm.org/D53170 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp Index: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp === --- clang-tools-extra/clang-

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

leonardchan added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:90-92 +static llvm::cl::opt +ClangDocExecutorName("doc-executor", llvm::cl::desc("The name of the executor to use in clang-doc."), + llvm::cl::init("all-TUs")); -

[PATCH] D53170: [clang-doc] Switch to default to all-TUs executor

juliehockett created this revision. juliehockett added reviewers: ioeric, leonardchan, jakehehrlich, lebedev.ri, phosek. juliehockett added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Since we generally want to document a whole project, not just one file. @ioeric,