nik added a comment.
Herald added a project: clang.
I've bisected https://bugs.llvm.org/show_bug.cgi?id=42646 to this change.
Reverting it fixes the issue.
Please look into it.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53191/new/
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345152: [clang] Introduce new completion context types
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53191?vs=170829&id=170901#toc
Repository:
rC Clang
ht
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
(sorry, thought I had accepted this!)
Repository:
rC Clang
https://reviews.llvm.org/D53191
___
cfe-commits mailing list
cfe-commits@list
kadircet updated this revision to Diff 170829.
kadircet marked an inline comment as done.
kadircet added a comment.
- Update comment.
Repository:
rC Clang
https://reviews.llvm.org/D53191
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Frontend/ASTUnit.cpp
lib/Sema/CodeCompleteCons
kadircet added a comment.
Since it doesn't change any CXCompletionContext's in CIndex it doesn't seem
possible. There are tests being added to
clangd(https://reviews.llvm.org/D53192), since it uses context provided by sema
to decide whether query the index or not, we can check the behavior.
R
sammccall added a comment.
Logic looks good. Any way we can exercise it with a test via c-index-test?
Comment at: include/clang/Sema/CodeCompleteConsumer.h:281
+
+/// Code completion occurred where an existing symbol is expected.
+CCC_Symbol,
nit: try t
kadircet marked 2 inline comments as done.
kadircet added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:277
+
+/// Code completion occurred where an existing name is expected.
+CCC_ExistingName,
sammccall wrote:
> It's not obvious
kadircet updated this revision to Diff 170677.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Use Symol, SymbolOrNewName, NewName
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D53191
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Frontend
sammccall added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:277
+
+/// Code completion occurred where an existing name is expected.
+CCC_ExistingName,
It's not obvious what "name" means here, e.g. what distinguishes this from
"
kadircet updated this revision to Diff 170631.
kadircet added a comment.
- Add comments.
Repository:
rC Clang
https://reviews.llvm.org/D53191
Files:
include/clang/Sema/CodeCompleteConsumer.h
lib/Frontend/ASTUnit.cpp
lib/Sema/CodeCompleteConsumer.cpp
lib/Sema/SemaCodeComplete.cpp
to
kadircet added a comment.
There are still some contexts where both a new name and an existing name is
permissible, going to add a comment on those to leave some traces for the next
person who cares
Repository:
rC Clang
https://reviews.llvm.org/D53191
_
11 matches
Mail list logo