This revision was automatically updated to reflect the committed changes.
Closed by commit rL357699: [RISCV] Collect library directories and triples for
riscv64 triple too (authored by asb, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: benna, psnobl, MaskRay.
This got missed somehow as I had a functionally identical patch in my local
development tree (though not with as thorough tests - thanks for that!).
edward-jones updated this revision to Diff 170374.
edward-jones marked 2 inline comments as done.
https://reviews.llvm.org/D53392
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/Inputs/basic_riscv64_tree/bin/riscv64-unknown-elf-ld
edward-jones updated this revision to Diff 170373.
edward-jones added a comment.
I've incorporated your suggested changes and added riscv32/64-linux-gnu entrys
to the Triple + LibDirs lists.
Is it worth also updating the riscv32-toolchain.c test in this patch to rename
jrtc27 added inline comments.
Comment at: test/Driver/riscv64-toolchain.c:71
+// RUN: %clang %s -### -no-canonical-prefixes -fuse-ld=ld \
+// RUN: -target riscv64-linux-unknown-elf \
+// RUN: --gcc-toolchain=%S/Inputs/multilib_riscv_linux_sdk \
This (and
jrtc27 added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1912
- static const char *const RISCV32LibDirs[] = {"/lib", "/lib32"};
+ static const char *const RISCVLibDirs[] = {"/lib", "/lib32"};
static const char *const RISCVTriples[] =
edward-jones created this revision.
edward-jones added a reviewer: asb.
Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o,
brucehoult, MartinMosbeck, rogfer01, mgrang, zzheng, jrtc27, shiva0217,
kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, arichardson,
