This revision was automatically updated to reflect the committed changes.
Closed by commit rL345022: [clangd] Support passing a relative path to
-compile-commands-dir (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
DaanDeMeyer added a comment.
You can commit them. Thanks for all the quick responses!
https://reviews.llvm.org/D53481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
It looks like these are your first couple of LLVM patches.
So, welcome :-) And do you want me to commit them for you?
Typically your first few patches get landed by someone else, and then you ask
for commit access:
DaanDeMeyer updated this revision to Diff 170384.
DaanDeMeyer added a comment.
Updated diff according to comments.
https://reviews.llvm.org/D53481
Files:
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
===
---
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for the fix!
Comment at: clangd/tool/ClangdMain.cpp:261
} else {
-CompileCommandsDirPath = CompileCommandsDir;
+// If the compile-commands-dir arg
DaanDeMeyer created this revision.
DaanDeMeyer added reviewers: clang-tools-extra, sammccall.
DaanDeMeyer added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
This is useful when using clangd with CMake based
