[PATCH] D53514: os_log: make buffer size an integer constant expression.

hiraditya closed this revision. hiraditya added a comment. Herald added a project: clang. closed in r345828, 314fbfa1c4c6665c54a220eefb10a6f23010a352 Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53514: os_log: make buffer size an integer constant expression.

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D53514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53514: os_log: make buffer size an integer constant expression.

t.p.northover updated this revision to Diff 172155. t.p.northover added a comment. Herald added a subscriber: mgorny. Same as previous patch except the OSLog helpers are moved to libclangAST to respect dependencies. Repository: rC Clang https://reviews.llvm.org/D53514 Files:

[PATCH] D53514: os_log: make buffer size an integer constant expression.

t.p.northover reopened this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Turns out I neglected the layering between libclangAST and libclangAnalysis so I've reverted for now. For this to work I think we need to move the OSLog helpers into

[PATCH] D53514: os_log: make buffer size an integer constant expression.

t.p.northover closed this revision. t.p.northover added a comment. Thanks Eli. I committed it as r345828, and then had to fixup some linker dependencies on other platforms, which took me a couple of tries (r345833 and r345835). Repository: rC Clang https://reviews.llvm.org/D53514

[PATCH] D53514: os_log: make buffer size an integer constant expression.

efriedma added subscribers: vsk, efriedma. efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D53514 ___ cfe-commits mailing list

[PATCH] D53514: os_log: make buffer size an integer constant expression.

t.p.northover added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D53514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53514: os_log: make buffer size an integer constant expression.

t.p.northover created this revision. Herald added a subscriber: mcrosier. The size of an os_log buffer is known at any stage of compilation, so making it a constant expression means that the common idiom of declaring a buffer for it won't result in a VLA. That allows the compiler to skip saving