[PATCH] D53591: Support the __gnu__ scoped attribute token

2018-10-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D53591#1273689, @rsmith wrote: > Looks good. Thanks! I've commit in r345132. > We should provide some reserved-name way of naming clang attributes too, but > I'm not sure what would be best

[PATCH] D53591: Support the __gnu__ scoped attribute token

2018-10-23 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good. We should provide some reserved-name way of naming clang attributes too, but I'm not sure what would be best (`__clang__` is a macro name). Maybe `_Clang`? (And maybe we should

[PATCH] D53591: Support the __gnu__ scoped attribute token

2018-10-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, echristo. Herald added a subscriber: krytarowski. GCC is currently considering a patch to accept `__gnu__` as a scoped attribute namespace that aliases to `gnu`. This is useful for libstdc++ so that they don't