erichkeane closed this revision.
erichkeane added a comment.
https://reviews.llvm.org/rL345302
https://reviews.llvm.org/D53718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane updated this revision to Diff 171163.
erichkeane edited the summary of this revision.
erichkeane added a comment.
Add to the test
https://reviews.llvm.org/D53718
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/keep-static-consts.cpp
Index: test/CodeGen/keep-static-consts.cpp
erichkeane added a comment.
In https://reviews.llvm.org/D53718#1276205, @zturner wrote:
> Will this work for the following variable?
>
> constexpr int N = 3;
>
Yep, just confirmed that it does! Adding to the test and will update the
review.
Repository:
rC Clang
zturner added a comment.
Will this work for the following variable?
constexpr int N = 3;
Repository:
rC Clang
https://reviews.llvm.org/D53718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erichkeane created this revision.
erichkeane added reviewers: rnk, zturner, eandrews.
To be more in line with what GCC does, switch the condition to be based
on the Static Storage duration instead of the storage class.
Repository:
rC Clang
https://reviews.llvm.org/D53718
Files:
