This revision was automatically updated to reflect the committed changes.
Closed by commit rG87cb734c04be: [Clang] Add VerboseOutputStream to
CompilerInstance (authored by scott.linder).
Herald added a project: clang.
Changed prior to commit:
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
___
scott.linder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder updated this revision to Diff 221089.
scott.linder added a comment.
Same patch, this time with a working test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
Files:
include/clang/Frontend/CompilerInstance.h
scott.linder updated this revision to Diff 221075.
scott.linder added a comment.
After reading again I think I understand the ask now. Is this closer to what
you had in mind?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
Files:
scott.linder marked an inline comment as done.
scott.linder added inline comments.
Comment at: include/clang/Frontend/CompilerInstance.h:362-363
+ /// If not set, this stream defaults to \c llvm::errs().
+ void setVerboseOutputStream(raw_ostream ,
+
dblaikie added inline comments.
Comment at: include/clang/Frontend/CompilerInstance.h:158-159
+ /// Whether we should delete VerboseOutputStream on destruction.
+ bool OwnsVerboseOutputStream = false;
+
Rather than a bool, this could be a unique_ptr,
scott.linder updated this revision to Diff 220396.
scott.linder added a comment.
Actually rebase this time
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/CompilerInstance.cpp
scott.linder updated this revision to Diff 220369.
scott.linder edited the summary of this revision.
scott.linder added reviewers: ddunbar, aprantl, cfang, dblaikie.
scott.linder added a comment.
Rebase and ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
scott.linder added a comment.
Ping
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53768/new/
https://reviews.llvm.org/D53768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
scott.linder added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D53768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D53768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scott.linder created this revision.
scott.linder added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
An attempt at removing one instance of a hardcoded output stream in
`CompilerInstance::ExecuteAction`. There are still other cases of output being
hard-coded to standard streams in
14 matches
Mail list logo
