[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355598: [ASTImporter] Changed use of Import to Import_New in ASTImporter. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D53818?vs=189696=189704#toc

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 189696. balazske added a comment. Herald added a reviewer: martong. Herald added a subscriber: jdoerfert. - Small style corrections. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 182866. balazske added a comment. - Small style corrections. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 179249. balazske added a comment. Rebase. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index:

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske reopened this revision. balazske added a comment. This revision is now accepted and ready to land. Reopening to fix failing lldb tests. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

davide added a comment. In D53818#1312133 , @martong wrote: > > I reverted this change because it breaks a bunch of lldb tests (on MacOS, > > and probably on other platforms too). To be clear, part of the reason I'm > > reacting strongly here is that

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

martong added a comment. > I reverted this change because it breaks a bunch of lldb tests (on MacOS, and > probably on other platforms too). To be clear, part of the reason I'm > reacting strongly here is that this is not the first patch this has come up > on. I'm worried about the broader

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

davide added a comment. I reverted this change because it breaks a bunch of lldb tests (on MacOS, and probably on other platforms too). To be clear, part of the reason I'm reacting strongly here is that this is not the first patch this has come up on. I'm worried about the broader trend of

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347752: [ASTImporter] Changed use of Import to Import_New in ASTImporter. (authored by balazske, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 175649. balazske added a comment. Rebase to newest master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index:

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

martong added a comment. In D53818#1307321 , @a_sidorin wrote: > LGTM. Thank you for addressing my questions! Hi Alexei, Could you please also take a look on that patch which this one depends on? https://reviews.llvm.org/D53751 I think the changes of

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM. Thank you for addressing my questions! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske added inline comments. Comment at: include/clang/AST/ASTImporter.h:192 /// -/// \returns the equivalent declaration in the "to" context, or a NULL type -/// if an error occurred. +/// \returns The equivalent declaration in the "to" context, or the

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske updated this revision to Diff 174168. balazske added a comment. - Small style corrections. Repository: rC Clang https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske marked 3 inline comments as done. balazske added a comment. If we change signature of `Import` now, other parts of the code (in clang and LLDB) would not compile (without changing to use the new kind of Import). If there is a `Import_New` the old code can still compile and can be

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

a_sidorin added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Hi Balasz, As I guess, the next step is to convert all `Import`calls to `Import_New` and then rename `Import_New` into `Import`. If so, why aren't we able to just change the behaviour of `Import`

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske added a comment. The Import functions are replaced by Import_New and error handling is added. This is done in the implementation of the Import_New functions itself, and in importInto. (Code of old Import functions is moved to the Import_New and updated to use Import_New.) Some other

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske created this revision. Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D53818 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp