[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

lebedev.ri added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// steveire wrote: > alexfh

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

steveire added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// alexfh wrote: > sammccall

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

sammccall added a comment. Fair enough. I think it's worth saying *something* here, as the stability of these API has value and churning them has costs that far exceed (2 of magnitude?) the other C++ APIs in clang-tidy. And out-of-tree dependencies are something I usually want to be aware of

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

sammccall updated this revision to Diff 172058. sammccall added a comment. Rethink comment about public API stability. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53936 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

alexfh added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// sammccall wrote: > steveire

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

sammccall added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// steveire wrote: > Clang C++

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

steveire added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// Clang C++ code does not have

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

sammccall updated this revision to Diff 171937. sammccall added a comment. Add FIXME to fuchsia check that uses private APIs. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53936 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. This codifies the mostly-current state: - The stuff in ClangTidy.h is reasonable for checks to depend on. - The stuff in ClangTidyDiagnosticConsumer.h is a mish-mash of