[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355331: [PGO] Clang part of change for context-sensitive PGO (part1) (authored by xur, committed by ). Changed prior to commit: https://reviews.llvm.org/D54176?vs=189167=189184#toc Repository: rC

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 ___ cfe-commits mailing list

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 189167. xur added a comment. Added usage example to UserManual.rst suggested by David. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files: docs/UsersManual.rst include/clang/Basic/CodeGenOptions.h

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl added inline comments. Comment at: docs/UsersManual.rst:1792 + The profile generated by ``-fcs-profile-generate`` and ``-fprofile-generate`` + can be merged by llvm-profdata. + Please add a use example to show the typical flow with this option (both

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 188955. xur added a comment. Integrated Teresa's suggestion to change the err() to assert. Added documentation change suggested by David. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files:

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl added a comment. Please add changes to option documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

tejohnson added a comment. Herald added a subscriber: jdoerfert. LGTM except for place noted below where I disagree with a change made earlier. Will let @davidxl chime in if he disagrees with me or has any other comments. Comment at: lib/CodeGen/BackendUtil.cpp:967 + if

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 186023. xur added a comment. Updated the patch to sync with D54175 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files: include/clang/Basic/CodeGenOptions.h

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 181587. xur added a comment. Update the patch to sync with https://reviews.llvm.org/D54175 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files: include/clang/Basic/CodeGenOptions.h

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

lebedev.ri added a comment. Clang reviews should mainly go to cfe-commits, not llvm-commits. (all that will happen automagically if one sets the correct repo for the differential..) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/