[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361116: [AVR] Automatically link CRT and libgcc from the system avr-gcc (authored by dylanmckay, committed by ). Herald

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added a comment. Herald added a project: clang. I'm very comfortable with the AVR changes at this point, I am going to go ahead and commit the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54334/new/ https://reviews.llvm.org/D54334

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay marked 3 inline comments as done. dylanmckay added a comment. > I'm not certain if it will be possible to devise test cases for the two > diagnostics I pointed out or not I don't think it will be. The compile warning logic works by directly querying the physical filesystem using the

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

aaron.ballman added a comment. I'm not certain if it will be possible to devise test cases for the two diagnostics I pointed out or not, but otherwise, this LGTM as far as the implementation goes. I don't know enough about AVR to sign off on whether the patch logic is correct or not.

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:44-45 +def warn_drv_avr_family_linking_stdlibs_not_implemented: Warning< + "support for linking stdlibs for microcontroller '%0' is not implemented, " + "please file an AVR backend bug

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay updated this revision to Diff 174362. dylanmckay marked an inline comment as done. dylanmckay added a comment. Run clang-format on the whole patch Repository: rC Clang https://reviews.llvm.org/D54334 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay updated this revision to Diff 174359. dylanmckay marked 6 inline comments as done. dylanmckay added a comment. - Remove link to BugZilla in diagnostic - Use StringRef for a static string array rather than std::string - Elide braces - Dereference an Optional in-place rather than

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:44-45 +def warn_drv_avr_family_linking_stdlibs_not_implemented: Warning< + "support for linking stdlibs for microcontroller '%0' is not implemented, " + "please file an AVR backend

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added a comment. I'd like feedback on the new AVR-specific warnings, and the new warning group. I have not added a warning or error to clang before, but this seems consistent with how the other targets implement it. Repository: rC Clang https://reviews.llvm.org/D54334

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay updated this revision to Diff 173722. dylanmckay added a comment. Add the search path that Ubuntu installs libc to. Repository: rC Clang https://reviews.llvm.org/D54334 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticGroups.td

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay created this revision. dylanmckay added reviewers: aaron.ballman, kparzysz, asb, hfinkel. This patch modifies the AVR toolchain so that if avr-gcc and avr-libc are detected during compilation, the CRT, libgcc, libm, and libc anre linked. This matches avr-gcc's default behaviour, and