[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus closed this revision. Szelethus added a comment. Commited in rC349274 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Thanks! I'll commit in a couple days to give some breathing room for anyone who'd object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D54401#1320772 , @Szelethus wrote: > In D54401#1318282 , @alexfh wrote: > > > In D54401#1315354

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. In D54401#1318282 , @alexfh wrote: > In D54401#1315354 , @NoQ wrote: > > > The code looks good, but i vaguely remember that we might accidentally > > break clang-tidy integration that

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

alexfh added a comment. In D54401#1315354 , @NoQ wrote: > The code looks good, but i vaguely remember that we might accidentally break > clang-tidy integration that uses this API to enable/disable specific checkers > via `-checks=-analyzer-...`. > >

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a reviewer: alexfh. Szelethus added a comment. *advanced summoning* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

NoQ added a subscriber: alexfh. NoQ added a comment. The code looks good, but i vaguely remember that we might accidentally break clang-tidy integration that uses this API to enable/disable specific checkers via `-checks=-analyzer-...`. *summons @alexfh* CHANGES SINCE LAST ACTION

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. Ping https://reviews.llvm.org/D54401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus updated this revision to Diff 173745. Szelethus edited the summary of this revision. Szelethus added a comment. Restored the discussed note. https://reviews.llvm.org/D54401 Files: include/clang/StaticAnalyzer/Core/CheckerRegistry.h

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:177 "no analyzer checkers are associated with '%0'">; -def note_suggest_disabling_all_checkers : Note< -"use -analyzer-disable-all-checks to disable all static analyzer

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

NoQ added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:177 "no analyzer checkers are associated with '%0'">; -def note_suggest_disabling_all_checkers : Note< -"use -analyzer-disable-all-checks to disable all static analyzer checkers">;

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. In https://reviews.llvm.org/D54401#1295832, @george.karpenkov wrote: > > Also, remove diags::note_suggest_disabling_all_checkers. > > Isn't that a separate revision? Given that removing existing options is often > questionable, I'd much rather see this patch

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

george.karpenkov added a comment. > Also, remove diags::note_suggest_disabling_all_checkers. Isn't that a separate revision? Given that removing existing options is often questionable, I'd much rather see this patch separated. Repository: rC Clang https://reviews.llvm.org/D54401

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

george.karpenkov added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:177 "no analyzer checkers are associated with '%0'">; -def note_suggest_disabling_all_checkers : Note< -"use -analyzer-disable-all-checks to disable all static analyzer

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus updated this revision to Diff 173717. Szelethus set the repository for this revision to rC Clang. Szelethus added a comment. Might as well make it a method. Repository: rC Clang https://reviews.llvm.org/D54401 Files: include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Thanks for taking a look! ^-^ Comment at: lib/StaticAnalyzer/Core/CheckerRegistry.cpp:51 -/// Collects the checkers for the supplied \p opt option into \p collected. -static void collectCheckers(const CheckerRegistry::CheckerInfoList , -

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

MTC added a comment. I'm totally fine with this patch personally. However I am not familiar with this part, so can't give substantial help :). Comment at: lib/StaticAnalyzer/Core/CheckerRegistry.cpp:51 -/// Collects the checkers for the supplied \p opt option into \p

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus updated this revision to Diff 173584. Szelethus added a comment. Also, remove `diags::note_suggest_disabling_all_checkers`. https://reviews.llvm.org/D54401 Files: include/clang/Basic/DiagnosticFrontendKinds.td include/clang/StaticAnalyzer/Core/CheckerRegistry.h

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. This bugged me for a long time, so it's time to put an end to it: