[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

This revision was automatically updated to reflect the committed changes. Closed by commit rL348244: [Analyzer] Iterator Checkers - Use the region of the topmost base class for… (authored by baloghadamsoftware, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54466/new/ https://reviews.llvm.org/D54466 ___ cfe-commits mailing list

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware updated this revision to Diff 176374. baloghadamsoftware added a comment. Now I think I understand the terminology and the concept so I could add Doxygen comment. I also refactored the code as you suggested, original code was based on `getBaseRegion()`. CHANGES SINCE LAST

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

NoQ added a comment. Huh, gotcha :) The nomenclature is mostly correct, just feels weird. Super-region of a region is a larger region. Sub-region is a smaller region. Base region is the largest non-memspace superregion, so it's a //larger// region. Derived class object is a large object. Base

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware updated this revision to Diff 175125. baloghadamsoftware added a comment. More standard-like tests. https://reviews.llvm.org/D54466 Files: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h lib/StaticAnalyzer/Checkers/IteratorChecker.cpp

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware added a comment. There is `CXXDerivedObjectRegion` as well. I am totally confused about the terminology now. Is there somewhere a documentation that explains all these things? If I make a

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

Szelethus added a comment. In https://reviews.llvm.org/D54466#1305305, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D54466#1297887, @NoQ wrote: > > > > Hmmm, shouldn't we add this to `MemRegion`'s interface instead? > > > This: > > > I wouldn't insist, but this does indeed sound

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware added a comment. In https://reviews.llvm.org/D54466#1297887, @NoQ wrote: > > I marked this patch as WIP because I could not create a test-case for it. > > However in real projects this patch seems to reduce false positives > > significantly. > > False positives are hard to

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware updated this revision to Diff 174917. baloghadamsoftware retitled this revision from "[Analyzer] [WIP] Iterator Checkers - Use the base region of C++ Base Object Regions (recursively) for iterators stored in a region" to "[Analyzer] Iterator Checkers - Use the region of the