[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

2018-11-15 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added a comment. I think you can safely abandon this change in favor of https://reviews.llvm.org/D54604 -- please join the review there. Repository: rC Clang https://reviews.llvm.org/D54473 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

2018-11-14 Thread Alexander Potapenko via Phabricator via cfe-commits
glider added inline comments. Comment at: include/clang/Basic/Sanitizers.def:163 +// Initialize local variables. +SANITIZER("init-locals", InitLocals) + lebedev.ri wrote: > Unless i'm mistaken, I suspect you may see some surprising behavior here, > unfortunately

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

2018-11-14 Thread Alexander Potapenko via Phabricator via cfe-commits
glider added a comment. In https://reviews.llvm.org/D54473#1297460, @kcc wrote: > This new flag inhibits the warnings from -Wuninitialized, right? > While this is fine for experimenting (and I want to have this in ToT to > enable wide experimentation) > we should clearly state (in the comment

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

2018-11-13 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added a comment. This new flag inhibits the warnings from -Wuninitialized, right? While this is fine for experimenting (and I want to have this in ToT to enable wide experimentation) we should clearly state (in the comments) that the final intent is to make the feature work together with -W

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

2018-11-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: include/clang/Basic/Sanitizers.def:163 +// Initialize local variables. +SANITIZER("init-locals", InitLocals) + Unless i'm mistaken, I suspect you may see some surprising behavior here, unfortunately. [[ https://bugs.

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

2018-11-13 Thread Alexander Potapenko via Phabricator via cfe-commits
glider created this revision. glider added reviewers: kcc, rjmccall, rsmith. Herald added a subscriber: cfe-commits. This patch adds a new feature, -fsanitize=init-locals, which generates zero initializers for uninitialized local variables. There's been discussions in the security community abou