jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Since you've already submitted a fix to Boost,
https://github.com/boostorg/build/commit/3385fe2aa699a45e722a1013658f824b6a7c761f,
I think this is fine to remove.
CHANGES SINCE LAST
riccibruno added inline comments.
Comment at: include/clang/Lex/Preprocessor.h:396
+ /// This is an alias for CurLexer.
PreprocessorLexer *CurPPLexer = nullptr;
erichkeane wrote:
> riccibruno wrote:
> > Would it make sense to remove this alias now that it
erichkeane marked 2 inline comments as done.
erichkeane added inline comments.
Comment at: include/clang/Lex/Preprocessor.h:396
+ /// This is an alias for CurLexer.
PreprocessorLexer *CurPPLexer = nullptr;
riccibruno wrote:
> Would it make sense to remove
riccibruno added a comment.
I looked at how `ASTReader` create the `IdentifierInfo`s returned by
`IdentifierInfo *ASTReader::get(StringRef Name)`,
and I ended up in `ASTIdentifierLookupTrait::ReadData`, which calls among other
things `IdentifierTable::getOwn`.
The `IdentifierInfo` created by
voskresensky.vladimir added a comment.
In https://reviews.llvm.org/D54547#1301359, @erichkeane wrote:
> > I thought clang-d service is using it to speed up indexing.
>
> Presumably, I could also just make PTH use another bit or two for the TokenID
> and it would work fine. However, when I
riccibruno added a comment.
> I thought clang-d service is using it to speed up indexing.
I believe that clangd is using PCH and not PTH.
(by the highly sophisticated method of grepping for pth and pch inside clangd/)
https://reviews.llvm.org/D54547
erichkeane added a comment.
In https://reviews.llvm.org/D54547#1301351, @voskresensky.vladimir wrote:
> I have some experience with PTH implementation, because had to fix it for
> Java-port of Clang (https://github.com/java-port/clank).
>
> It was sometime ago, but making it completely workable
voskresensky.vladimir added a comment.
I have some experience with PTH implementation, because had to fix it for
Java-port of Clang (https://github.com/java-port/clank).
It was sometime ago, but making it completely workable was not hard.
As I remember the key fix was just to have PTH be
erichkeane added a comment.
In https://reviews.llvm.org/D54547#1301253, @arphaman wrote:
> Would it be better to deprecate the use of PTH right now for the current
> release, so that the users will be aware that we will remove PTH support in
> LLVM 9 once they upgrade to LLVM 8? Then we can
arphaman added a comment.
Would it be better to deprecate the use of PTH right now for the current
release, so that the users will be aware that we will remove PTH support in
LLVM 9 once they upgrade to LLVM 8? Then we can remove it right after LLVM 8
branch is created.
riccibruno added a comment.
In https://reviews.llvm.org/D54547#1299883, @erichkeane wrote:
> Added to the release notes. Also, an email was sent out to cfe-dev.
>
> @riccibruno and I are separately looking into IdentifierInfo, because it
> seems that there are some pretty massive optimization
riccibruno added a comment.
I don't think I can comment more broadly on this, but
there is some PTH-related code in `Basic/IdentifierTable`,
in `IdentifierInfo::getNameStart` and `IdentifierInfo::getLength`.
Maybe this should be removed too ?
Repository:
rC Clang
aaron.ballman added a comment.
In https://reviews.llvm.org/D54547#1299105, @chandlerc wrote:
> Should likely add release notes about this.
>
> Also might be worth sending a note to cfe-dev as a heads up and give folks
> some time to say "wait wait".
+1 to both of these points, but if doesn't
chandlerc added a comment.
Should likely add release notes about this.
Also might be worth sending a note to cfe-dev as a heads up and give folks some
time to say "wait wait".
Repository:
rC Clang
https://reviews.llvm.org/D54547
___
erichkeane added inline comments.
Comment at: include/clang/Driver/Options.td:261
MetaVarName<"">;
-def ccc_pch_is_pch : Flag<["-"], "ccc-pch-is-pch">, InternalDriverOpt,
- HelpText<"Use lazy PCH for precompiled headers">;
The default behavior is exactly to
15 matches
Mail list logo
