[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rjmccall added a comment. Oh, I see this review might be dead in the water; I'm not sure why I was just added as a reviewer to it (by a non-author, no less). I personally have no problem with pulling out specific features as sub-groups of the compatibility warning. I agree with Richard,

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rjmccall added a comment. I doubt "CTAD" is going to survive as a term that people recognize and remember, and I don't think `-Wclass-template-argument-deduction` is outrageously wordy compared to some of our other diagnostic groups. With that change, this would be fine with me. Repository:

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

Quuxplusone added a comment. > - using CTAD on arbitrary class templates that weren't designed for it > creates a source compatibility problem that the class template author has no > control over nor say in > - using CTAD on class templates that were designed for it does not create a > new

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

rsmith added a comment. >> I think there is a case to be made for warning on this specific language >> feature, because using CTAD on class templates that weren't designed for it >> is dangerous and creates source compatibility problems for future changes to >> that library. > > Personally I

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

Quuxplusone added a comment. In D54565#1339454 , @thakis wrote: > Since I don't know what it means, I don't know if I want a diagnostic for it > :-) Fair point. ;) But the full text of the diagnostic message does say "class template argument deduction

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

thakis added a comment. In D54565#1331293 , @Quuxplusone wrote: > @rsmith ping! > > @thakis: You said, //"From a user point of view, I have no idea what "CTAD" > means, and I sometimes work on a C++ compiler."// Did you mean "I think the > command-line

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

Quuxplusone added a comment. @rsmith ping! It's been a week since the last ping... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54565/new/ https://reviews.llvm.org/D54565 ___ cfe-commits mailing list

[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

Quuxplusone added a comment. @rsmith ping! @thakis: You said, //"From a user point of view, I have no idea what "CTAD" means, and I sometimes work on a C++ compiler."// Did you mean "I think the command-line option should be named something more verbose than `-W[c++14-compat-]ctad`"? Or "I