This revision was automatically updated to reflect the committed changes.
Closed by commit rL347863: Set MustBuildLookupTable on PrimaryContext in
ExternalASTMerger (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
shafik added a comment.
Apologies, I meant to make the comment in the child PR
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54898/new/
https://reviews.llvm.org/D54898
___
cfe-commits mailing list
davide added a comment.
This doesn't break anything, and I'm fairly confident Raphael (@teemperor) ran
the tests.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54898/new/
https://reviews.llvm.org/D54898
___
shafik added a comment.
As pointed out in this comment in another review
https://reviews.llvm.org/D44100#1311687
We need to make sure we are running the lldb test suite before committing and
watching the bots to make sure the commit does not break them.
Thank you
Repository:
rC Clang
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54898/new/
https://reviews.llvm.org/D54898
___
teemperor created this revision.
teemperor added reviewers: martong, a.sidorin.
teemperor added a project: LLDB.
Herald added subscribers: cfe-commits, rnkovacs.
`MustBuildLookupTable` must always be called on a primary context as we
otherwise
trigger an assert, but we don't ensure that this
