This revision was automatically updated to reflect the committed changes.
Closed by commit rL348134: [Sema] Avoid CallExpr::setNumArgs in
Sema::BuildCallToObjectOfClassType (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54900/new/
https://reviews.llvm.org/D54900
riccibruno updated this revision to Diff 175431.
riccibruno marked 3 inline comments as done.
riccibruno added a comment.
fixed the formatting
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54900/new/
https://reviews.llvm.org/D54900
Files:
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:13260
+ // The number of arguments slots to allocate in the call.
+ // If we have default arguments we need to allocate space for them
arguments -> argument
Also, I think this
riccibruno created this revision.
riccibruno added reviewers: rsmith, aaron.ballman.
riccibruno added a project: clang.
Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini.
`CallExpr::setNumArgs` is the only thing that prevents storing the arguments
of a call expression in a
