bruno abandoned this revision.
bruno added a comment.
Abandon this one in favor of https://reviews.llvm.org/D55676
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54923/new/
https://reviews.llvm.org/D54923
___
cfe-commits mailing list
bruno added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54923/new/
https://reviews.llvm.org/D54923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54923/new/
https://reviews.llvm.org/D54923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
@rsmith this is on the non-determinism issue we discussed offline. Do you have
any concerns with this approach?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54923/new/
https://reviews.llvm.org/D54923
___
bruno added a comment.
Although we can't synthesize a testcase for inclusion in the patch. Here is how
one should attempt to reproduce the problem in macOS 10.14.
echo '@import Foundation;' > test.m
clang -fmodules test.m -o test.o -c \
-fmodules-cache-path=/tmp/cache \
bruno created this revision.
bruno added reviewers: rsmith, v.g.vassilev.
Herald added subscribers: dexonsmith, mgrang, jkorous.
A module signature hashes out all relevant content in a module in order
to guarantee that in a dep chain, an inconsistent module never gets
imported. When using
