[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. I am planning to revert it because of https://bugs.llvm.org/show_bug.cgi?id=41161 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

This revision was automatically updated to reflect the committed changes. Closed by commit rL348352: [clang] - Simplify tools::SplitDebugName. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

dblaikie accepted this revision. dblaikie added subscribers: labath, klimek. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - tagging @labath @klimek here in case they have some further context on whether this is the right place for the test. But I'm

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1316985 , @JonasToth wrote: > from my side no objections, mailing list did not react AFAIK (just in case > your waiting for me until you recommit). David requested the test case, I added it and now waiting for his

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

JonasToth added a comment. from my side no objections, mailing list did not react AFAIK (just in case your waiting for me until you recommit). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 ___

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar updated this revision to Diff 175843. grimar added a comment. - Added the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 Files: lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1312012 , @JonasToth wrote: > The issues seems to be resolved for me as well, i will post this patch to the > mailing list and ask the other guy if his build is fine, too. Thanks, Jonas! CHANGES SINCE LAST ACTION

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

JonasToth added a comment. The issues seems to be resolved for me as well, i will post this patch to the mailing list and ask the other guy if his build is fine, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1311400 , @dblaikie wrote: > In D55006#1311398 , @grimar wrote: > > > In D55006#1311391 , @dblaikie > > wrote: > > > > > Cool - thanks!

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

dblaikie added a comment. In D55006#1311398 , @grimar wrote: > In D55006#1311391 , @dblaikie wrote: > > > Cool - thanks! Any chance/way to add a test for this that'd show up sooner > > than the breakage caused by

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1311391 , @dblaikie wrote: > Cool - thanks! Any chance/way to add a test for this that'd show up sooner > than the breakage caused by the previous version? Maybe, I am not sure. I was not able to trigger this without

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

JonasToth added a comment. Thank you for the fix! I will try this version as soon as I am at home (~2 hours from now) and report back if the issues I had are gone. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

dblaikie added a comment. Cool - thanks! Any chance/way to add a test for this that'd show up sooner than the breakage caused by the previous version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. With that the original issue mentioned in the following comment is fixed for me: https://reviews.llvm.org/rL347035#299232 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 ___

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar created this revision. grimar added reviewers: dblaikie, JonasToth. This is an updated version of the D54576 , which was reverted. Problem was that `SplitDebugName` calls the `InputInfo::getFilename` which asserts if `InputInfo` given is not of type