This revision was automatically updated to reflect the committed changes.
Closed by commit rL348101: Replace FullComment member being visited with
parameter (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55070/new/
https://reviews.llvm.org/D55070
steveire updated this revision to Diff 175966.
steveire added a comment.
Remove &&
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55070/new/
https://reviews.llvm.org/D55070
Files:
include/clang/AST/CommentVisitor.h
lib/AST/ASTDumper.cpp
Index:
steveire updated this revision to Diff 175963.
steveire added a comment.
Remove param
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55070/new/
https://reviews.llvm.org/D55070
Files:
lib/AST/ASTDumper.cpp
Index: lib/AST/ASTDumper.cpp
steveire updated this revision to Diff 175968.
steveire added a comment.
Rebase
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55070/new/
https://reviews.llvm.org/D55070
Files:
lib/AST/ASTDumper.cpp
Index: lib/AST/ASTDumper.cpp
aaron.ballman added a comment.
This is a really nice cleanup, thank you!
Comment at: lib/AST/ASTDumper.cpp:114-115
+public ConstStmtVisitor,
+public CommentVisitorBase,
+public TypeVisitor {
Why not inherit from `ConstCommentVisitor`
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D55070
Files:
lib/AST/ASTDumper.cpp
Index: lib/AST/ASTDumper.cpp
